🌱 Bump CAPI to v1.8.5 #632
Conversation
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
furkatgofurov7
force-pushed
the
bump-capi-1-8
branch
3 times, most recently
from
266b483
to
36f98fb
Compare
furkatgofurov7
force-pushed
the
bump-capi-1-8
branch
2 times, most recently
from
6dc4dbc
to
29f4bd3
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
bump-capi-1-8
branch
2 times, most recently
from
86dba88
to
3b6be2b
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
bump-capi-1-8
branch
from
3b6be2b
to
c7b9c24
Compare
|
@furkatgofurov7: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks @furkatgofurov7. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 227ed7ea918fd5106eed36170b2fb6330d76a976
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Follows: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.7-to-v1.8 to bump Cluster API to v1.8.5, the latest version in v1.8.x series, as is now.
Additionally, there were a couple of changes included in the same patch, since there was a circular dependency among cluster API and controller runtime dependencies:
The
sigs.k8s.io/controller-runtime/pkg/config/v1alpha1package utilized in v1alpha1 of our API has been deprecated (refer to RFC: Deprecation and removal of ComponentConfig controller-runtime#895). Consequently, updating to a new Cluster API version, which removesComponentConfig, forced us to develop a custom config loader for the v1alpha1 API. It’s important to note that we successfully transitioned fromComponentConfigto its new alternative in v1alpha2 of our API, as detailed in v1alpha2? #167 (comment), but package usage remained in v1alpha1 API.The size of this patch has increased due to several interdependencies that could not be split into separate PRs (the Cluster API update requires a new controller runtime, which in turn needs a custom config). Despite this, hopefully reviewing it should be still relatively straight-forward. Key reasons for the expanded diffs include:
Due to these necessary changes to v1alpha1, the
api-diffCI will fail.Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #566